From 58347af9983489dd2df25b4e954d2f2050ff5fa2 Mon Sep 17 00:00:00 2001 From: awsr <43862868+awsr@users.noreply.github.com> Date: Sat, 24 Jan 2026 16:12:17 -0800 Subject: [PATCH] Fix logic error and update syntax --- javascript/settings.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/javascript/settings.js b/javascript/settings.js index 537bfd7f0..ed564b29c 100644 --- a/javascript/settings.js +++ b/javascript/settings.js @@ -25,17 +25,15 @@ async function updateOpts(json_string) { const t1 = performance.now(); for (const op of monitoredOpts) { - const key = Object.keys(op)[0]; - const callback = op[key]; - if (opts[key] && opts[key] !== settings_data.values[key]) { - log('updateOpt', key, opts[key], settings_data.values[key]); + const [key, callback] = Object.entries(op)[0]; + if (Object.hasOwn(opts, key) && opts[key] !== new_opts[key]) { + log('updateOpt', key, opts[key], new_opts[key]); if (callback) callback(new_opts[key], opts[key]); } } for (const op of AppyOpts) { - const key = Object.keys(op)[0]; - const callback = op[key]; + const [key, callback] = Object.entries(op)[0]; if (callback) callback(new_opts[key], opts[key]); }